add default-domains-netblock for google_netblock_ip_ranges data source #10821
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 203 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccApigeeSyncAuthorization_update|TestAccBinaryAuthorizationAttestor_kms|TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample|TestAccCloudAssetOrganizationFeed_cloudAssetOrganizationFeedExample|TestAccCloudAssetProjectFeed_cloudAssetProjectFeedExample|TestAccCloudBuildBitbucketServerConfig_cloudbuildBitbucketServerConfigPeeredNetworkExample|TestAccCloudBuildTrigger_cloudbuildTriggerServiceAccountExample|TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample|TestAccCloudBuildTrigger_webhook_config|TestAccCloudFunctionsFunction_dockerRepository|TestAccCloudFunctionsFunction_secretEnvVar|TestAccCloudFunctionsFunction_secretMount|TestAccCloudFunctionsFunction_serviceAccountEmail|TestAccCloudFunctionsFunction_vpcConnector|TestAccCloudIdsEndpoint_basic|TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceSecretVolumesExample|TestAccCloudRunService_secretEnvironmentVariable|TestAccCloudRunService_secretVolume|TestAccCloudSchedulerJob_schedulerJobOauthExample|TestAccCloudSchedulerJob_schedulerJobOidcExample|TestAccCloudbuildWorkerPool_withNetwork|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccComposer1Environment_withNodeConfig|TestAccComposer2Environment_withNodeConfig|TestAccComposerEnvironment_fixPyPiPackages|TestAccComposerEnvironment_withEncryptionConfigComposer1|TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeAutoscaler_scaleInControl|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_update|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeInstanceGroup_rename|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstanceTemplate_sourceImageEncryptionKey|TestAccComputeInstance_guestAccelerator|TestAccComputePerInstanceConfig_removeInstanceOnDestroy|TestAccComputePerInstanceConfig_statefulIps|TestAccComputePerInstanceConfig_update|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_update|TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey|TestAccComputeTargetPool_basic|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_nodeAutoprovisioningNetworkTags|TestAccContainerCluster_resourceManagerTags|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withAddons|TestAccContainerCluster_withAutopilot|TestAccContainerCluster_withAutopilotResourceManagerTags|TestAccContainerCluster_withFQDNNetworkPolicy|TestAccContainerCluster_withGcpPublicCidrsAccessEnabledToggle|TestAccContainerCluster_withNodePoolCIA|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_withVersion|TestAccContainerCluster_withWorkloadALTSConfig|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerNodePool_resourceManagerTags|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withReservationAffinitySpecific|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccDataFusionInstance_dataFusionInstanceCmekExample|TestAccDataFusionInstance_dataFusionInstanceFullExample|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydb|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample|TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample|TestAccDataplexTaskDataplexTask_update|TestAccDataplexTaskIamBindingGenerated|TestAccDataplexTaskIamMemberGenerated|TestAccDataplexTaskIamPolicyGenerated|TestAccDataplexTask_dataplexTaskBasicExample|TestAccDataplexTask_dataplexTaskNotebookExample|TestAccDataplexTask_dataplexTaskSparkExample|TestAccDialogflowCXWebhook_update|TestAccEdgecontainerCluster_edgecontainerClusterExample|TestAccEdgecontainerCluster_edgecontainerClusterWithMaintenanceWindowExample|TestAccEssentialContactsContact_essentialContactExample|TestAccEssentialContactsContact_update|TestAccEventarcChannel_basic|TestAccEventarcChannel_cryptoKeyUpdate|TestAccEventarcGoogleChannelConfig_cryptoKeyUpdate|TestAccEventarcTrigger_HttpDest|TestAccEventarcTrigger_channel|TestAccFirestoreDatabase_firestoreCmekDatabaseExample|TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample|TestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_resourceManagerTags|TestAccInstanceGroupManager_self_link_unique|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_versions|TestAccInstanceGroupManager_waitForStatus|TestAccIntegrationConnectorsConnection|TestAccIntegrationConnectorsEndpointAttachment_integrationConnectorsEndpointAttachmentExample_update|TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update|TestAccKmsCryptoKeyVersion_externalProtectionLevelOptions|TestAccLoggingBucketConfigBillingAccount_basic|TestAccLoggingBucketConfigOrganization_basic|TestAccLoggingBucketConfigOrganization_indexConfigs|TestAccLoggingOrganizationSettings_update|TestAccLoggingProjectSink_updatePreservesCustomWriter|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccMemcacheInstance_memcacheInstanceBasicTestExample|TestAccMemcacheInstance_update|TestAccMonitoringSlo_availabilitySli|TestAccMonitoringSlo_basic|TestAccMonitoringSlo_monitoringSloAppengineExample|TestAccMonitoringSlo_windowBasedGoodTotalRatioThresholdSlis|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNetworkManagementConnectivityTest_update|TestAccNetworkSecurityGatewaySecurityPolicy_networkSecurityGatewaySecurityPolicyTlsInspectionBasicExample|TestAccNetworkSecurityServerTlsPolicy_networkSecurityServerTlsPolicyMtlsExample|TestAccNetworkSecurityTlsInspectionPolicy_networkSecurityTlsInspectionPolicyBasicExample|TestAccNetworkSecurityTlsInspectionPolicy_update|TestAccNotebooksInstance_notebookInstanceFullExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample|TestAccPubsubLiteReservation_pubsubLiteReservationBasicExample|TestAccPubsubLiteSubscription_pubsubLiteSubscriptionBasicExample|TestAccPubsubLiteTopic_pubsubLiteTopicBasicExample|TestAccPubsubSubscriptionBigQuery_update|TestAccPubsubSubscriptionCloudStorage_update|TestAccPubsubSubscription_pubsubSubscriptionPushBqExample|TestAccPubsubSubscription_pubsubSubscriptionPushBqTableSchemaExample|TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageAvroExample|TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageExample|TestAccPubsubSubscription_push|TestAccPubsubSubscription_pushNoWrapper|TestAccPubsubSubscription_pushNoWrapperEmpty|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstanceMrrExample|TestAccRedisInstance_redisInstancePrivateServiceTestExample|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_resourceManagerTags|TestAccRegionInstanceGroupManager_stateful|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_update|TestAccRegionInstanceGroupManager_versions|TestAccSecretManagerSecret_automaticCmekUpdate|TestAccSecretManagerSecret_cmek|TestAccSecretManagerSecret_rotationPeriodUpdate|TestAccSecretManagerSecret_secretWithAutomaticCmekExample|TestAccSecretManagerSecret_userManagedCmekUpdate|TestAccSecureSourceManagerInstance_secureSourceManagerInstanceCmekExample|TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivateExample|TestAccServiceDirectoryEndpoint_serviceDirectoryEndpointWithNetworkExample|TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample|TestAccStorageInsightsReportConfig_update|TestAccStorageNotification_basic|TestAccStorageNotification_withEventsAndAttributes|TestAccStorageTransferAgentPool_agentPoolUpdate|TestAccStorageTransferJob_basic|TestAccStorageTransferJob_eventStream|TestAccStorageTransferJob_notificationConfig|TestAccStorageTransferJob_objectConditions|TestAccStorageTransferJob_omitScheduleEndDate|TestAccStorageTransferJob_posixSink|TestAccStorageTransferJob_posixSource|TestAccStorageTransferJob_transferJobName|TestAccStorageTransferJob_transferOptions|TestAccTPUNode_tpuNodeBUpdateTensorFlowVersion|TestAccTPUNode_tpuNodeBasicExample|TestAccTPUNode_tpuNodeFullTestExample|TestAccTags|TestAccTagsLocationTagBinding_locationTagBindingzonal|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIEndpointIamBinding|TestAccVertexAIEndpointIamMember|TestAccVertexAIEndpointIamPolicy|TestAccVertexAIEndpoint_vertexAiEndpointNetwork|TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewExample|TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewWithVectorSearchExample|TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated|TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsBigtableExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample|TestAccVertexAIIndexEndpoint_updated|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointTestExample|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointWithPscExample|TestAccVertexAITensorboard_vertexAiTensorboardFullExample|TestAccWorkstationsWorkstationCluster_Private_update|TestAccWorkstationsWorkstationCluster_update|TestAccWorkstationsWorkstationCluster_workstationClusterBasicExample|TestAccWorkstationsWorkstationCluster_workstationClusterCustomDomainExample|TestAccWorkstationsWorkstationCluster_workstationClusterPrivateExample |
|
This PR has been waiting for review for 2 weekdays. Please take a look! Use the label |
|
/gcbrun |
modular-magician
added
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 24 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAppEngineFlexibleAppVersion_update|TestAccComposer1Environment_withNodeConfig|TestAccComposerEnvironment_fixPyPiPackages|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstance_guestAccelerator|TestAccComputePerInstanceConfig_removeInstanceOnDestroy|TestAccComputePerInstanceConfig_statefulIps|TestAccComputePerInstanceConfig_update|TestAccContainerCluster_withAutopilotResourceManagerTags|TestAccInstanceGroupManager_resourceManagerTags|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_versions|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_resourceManagerTags|TestAccRegionInstanceGroupManager_stateful|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_versions|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIEndpointIamBinding|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample |
|
|
There was a problem hiding this comment.
👋 Hi!
TestAccDataSourceGoogleNetblockIpRanges_basic is the only test using this data source, so we can ignore the failures listed in the comments.
I've triggered that test to run on this PR in our (private) testing environment, once I see the outcome I'll re-review.
add default-domains-netblock for google_netblock_ip_ranges data source
fix hashicorp/terraform-provider-google#15339
PR taken from hashicorp/terraform-provider-google#9326 and change the library for acceptance
Release Note Template for Downstream PRs (will be copied)